-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use modern solution for tri-layer in sofle default layout #19113
Conversation
Just a heads up, either version is valid, and have their own quirks. Like the layer state function won't let you activate the third layer (the "adjust" layer here) without the first two layers (raise and lower, here) being active. That may not be desirable behavior, in some cases/configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wont work as KC_LOWER and friends are now a non implemented keycodes.
They need to be removed from the custom keycodes enum, and replaced with,
#define KC_LOWER MO(_LOWER)
As per [docs](https://github.com/qmk/qmk_firmware/blob/master/docs/ref_functions.md#update_tri_layer_statestate-x-y-z) handling it in process_record_user is no longer necessary
5f6ca8c
to
f37aaa2
Compare
@drashna, I knew about this limitation, but aforementioned feature (activating @zvecr, thanks for spotting the issue, pushed the change with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Equivalent as long as you do not need to do MO(_ADJUST)
Description
As per docs handling it in
process_record_user
is no longer necessary.I don't own OLED version, so I'd like to ask the dear reviewer to verify if
print_status_narrow
still works properly after that change.Types of Changes
Checklist