Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern solution for tri-layer in sofle default layout #19113

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

rafal0p
Copy link
Contributor

@rafal0p rafal0p commented Nov 19, 2022

Description

As per docs handling it in process_record_user is no longer necessary.

I don't own OLED version, so I'd like to ask the dear reviewer to verify if print_status_narrow still works properly after that change.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Nov 20, 2022

Just a heads up, either version is valid, and have their own quirks. Like the layer state function won't let you activate the third layer (the "adjust" layer here) without the first two layers (raise and lower, here) being active. That may not be desirable behavior, in some cases/configs.

@drashna drashna requested a review from a team November 20, 2022 07:41
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wont work as KC_LOWER and friends are now a non implemented keycodes.

They need to be removed from the custom keycodes enum, and replaced with,

#define KC_LOWER MO(_LOWER)

@rafal0p rafal0p force-pushed the sofle-default-update-tri-layer branch from 5f6ca8c to f37aaa2 Compare November 20, 2022 15:53
@rafal0p
Copy link
Contributor Author

rafal0p commented Nov 20, 2022

@drashna, I knew about this limitation, but aforementioned feature (activating _ADJUST directly) is not not present in the default layout. But maybe you're right, and for educational purposes it's actually better to leave it as-is?

@zvecr, thanks for spotting the issue, pushed the change with MO(_LOWER) (instead of #define), do you happen to know if they are equivalent?

Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalent as long as you do not need to do MO(_ADJUST)

@zvecr zvecr merged commit 852952c into qmk:master Nov 20, 2022
@rafal0p rafal0p deleted the sofle-default-update-tri-layer branch November 20, 2022 18:19
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants