Specify DEFAULT_FOLDER for v2/splinky
#19093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QMK's `list-keyboards` infer a keyboard directory by looking for a `rules.mk` file. Because `v2/splinky/v2` and `v2/splinky/v3` share some `rules.mk` definition in `v2/splinky/rules.mk`, `multibuild` attempts to build them, which fails because `POINTING_DEVICE_CS_PIN` is only defined for the leaf folders. This commit allows us to default to `v3` by specifying `DEFAULT_FOLDER` in `v2/splinky/rules.mk`
14 tasks
drashna
approved these changes
Nov 16, 2022
tzarc
approved these changes
Nov 16, 2022
dkruyt
pushed a commit
to dkruyt/qmk_firmware
that referenced
this pull request
Nov 18, 2022
thystips
pushed a commit
to thystips/qmk_firmware
that referenced
this pull request
Nov 24, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QMK's
list-keyboardsinfer a keyboard directory by looking for arules.mkfile. Becausev2/splinky/v2andv2/splinky/v3share somerules.mkdefinition inv2/splinky/rules.mk,multibuildattempts to build them, which fails becausePOINTING_DEVICE_CS_PINis only defined for the leaf folders.This commit allows us to default to
v3by specifyingDEFAULT_FOLDERinv2/splinky/rules.mkDescription
Types of Changes
Issues Fixed or Closed by This PR
Checklist