-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Support inverted scan logic for optical switches #19053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some optical switch designs use inverted logic. Just define PRESSED_KEY_PIN_STATE 1 to enable output in config.h
one reading on GPIO to avoid erroneous readout
Update on now stale #16340.
|
Some thoughts on this can be found in SonixQMK#299 |
functionality verified with no adverse effects in either input logic state |
drashna
approved these changes
Nov 20, 2022
14 tasks
tzarc
approved these changes
Dec 8, 2022
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
14 tasks
ssgelm
pushed a commit
to ssgelm/qmk_firmware
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit f2a8a13 on qmk/qmk_firmware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optical switch designs use inverted logic for pressed state.
To invert the keypress logic, configure
matrix_pins.input_pressed_state
in info.json:or, define
MATRIX_INPUT_PRESSED_STATE 1
in config.hDescription
Types of Changes
Issues Fixed or Closed by This PR
Checklist