Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ducky One 2 SF: Adjust fn layer mappings #18955

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Ducky One 2 SF: Adjust fn layer mappings #18955

merged 1 commit into from
Nov 20, 2022

Conversation

hugglesfox
Copy link
Contributor

@hugglesfox hugglesfox commented Nov 5, 2022

Description

One of the features of the Ducky One 2 SF is that it makes heavy use of it's function layer to provide additional functionality and alternate key mappings. This PR modifies the default keymap to make the default QMK function layer key mapping closer to that of the original firmware.

The main differences between the QMK fn layer mapping and the original mappings are the backlight controls and macro recording bindings as they don't map 1 to 1 with the QMK available key codes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

cc: @f7urry

Make the function layer key mappings closer to that of the original
firmware
@github-actions github-actions bot added the keymap label Nov 5, 2022
@drashna drashna self-requested a review November 19, 2022 19:49
@drashna drashna requested a review from a team November 19, 2022 19:49
@drashna drashna merged commit eb63857 into qmk:master Nov 20, 2022
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants