Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

userspace: fix up sethBarberee sinc keymap CI errors #18865

Merged
merged 1 commit into from
Oct 27, 2022
Merged

userspace: fix up sethBarberee sinc keymap CI errors #18865

merged 1 commit into from
Oct 27, 2022

Conversation

SethBarberee
Copy link
Contributor

Fix up my userspace/keymap so sinc compiles them fine.

Description

Surround my RGBLIGHT defines in ifdef/endif

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 27, 2022 04:24
@zvecr zvecr merged commit 18a7045 into qmk:master Oct 27, 2022
hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
@SethBarberee @hirakiuc
userspace: fix up sethBarberee sinc keymap CI errors (qmk#18865)
f1e056f
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@SethBarberee
userspace: fix up sethBarberee sinc keymap CI errors (qmk#18865)
a858610
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@SethBarberee @thystips
userspace: fix up sethBarberee sinc keymap CI errors (qmk#18865)
43379de
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@SethBarberee @ramonimbao
userspace: fix up sethBarberee sinc keymap CI errors (qmk#18865)
f0bf15f
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@SethBarberee @nolanseaton
userspace: fix up sethBarberee sinc keymap CI errors (qmk#18865)
ac129f4
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@SethBarberee @ChrisChrisLoLo
userspace: fix up sethBarberee sinc keymap CI errors (qmk#18865)
2750366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SethBarberee @fauxpark @zvecr