Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix splitkb/aurora/sweep #18839

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Fix splitkb/aurora/sweep #18839

merged 2 commits into from
Oct 25, 2022

Conversation

fauxpark
Copy link
Member

Description

image
caused by:

json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 74 column 9 (char 6074)

Technically qmk_api_tasks should be able to understand hjson, but until then...

cc @leah-splitkb

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 25, 2022 04:46
@drashna drashna requested a review from a team October 25, 2022 05:01
@leah-splitkb
Copy link
Contributor

Will this be rolled back once qmk_api_tasks gets proper hjson support?
Also, doesn't getting rid of layout_aliases break keymap compatibility?

@fauxpark
Copy link
Member Author

Yes, I just got back to this.

@zvecr zvecr merged commit 5d8c8a6 into qmk:master Oct 25, 2022
@fauxpark fauxpark deleted the aurora-sweep-info-fix branch October 25, 2022 13:45
hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
@fauxpark @hirakiuc
Fix splitkb/aurora/sweep (qmk#18839)
88eedb7 
* Fix splitkb/aurora/sweep

* Add back layout alias
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@fauxpark
Fix splitkb/aurora/sweep (qmk#18839)
942d8c6 
* Fix splitkb/aurora/sweep

* Add back layout alias
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@fauxpark @thystips
Fix splitkb/aurora/sweep (qmk#18839)
623f635 
* Fix splitkb/aurora/sweep

* Add back layout alias
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Fix splitkb/aurora/sweep (qmk#18839)
6c0fc18 
* Fix splitkb/aurora/sweep

* Add back layout alias
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@fauxpark @nolanseaton
Fix splitkb/aurora/sweep (qmk#18839)
d2dccc2 
* Fix splitkb/aurora/sweep

* Add back layout alias
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@fauxpark @ChrisChrisLoLo
Fix splitkb/aurora/sweep (qmk#18839)
c3c37cf 
* Fix splitkb/aurora/sweep

* Add back layout alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @leah-splitkb @drashna @zvecr