Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some assumptions on sequential keycode ranges #18838

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Remove some assumptions on sequential keycode ranges #18838

merged 2 commits into from
Oct 25, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 25, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 25, 2022 00:30
@zvecr zvecr requested a review from drashna October 25, 2022 00:34
@drashna
Copy link
Member

drashna commented Oct 25, 2022

Yeah, those were added like that since the ranges were sequential. When that changes, yeah ... better to have the ranges explicitly enumerated.

@drashna drashna merged commit 4f63be4 into qmk:develop Oct 25, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Remove some assumptions on sequential keycode ranges (qmk#18838)
1e0a9b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark