Adjust oled gen to fix flashing on timeout #18747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue in Ocean Dream that causes flashing after the oled screen times out and turns off. This occurs because writing to an OLED screen turns it on as well and we are both writing then immediately turning the screen off, but only if the timeout has occurred (no WPM, 30 seconds has passed).
|
@keyboard-magpie @precondition I think this should fix some of the other problems with the OLED code that y'all were talking about. hopefully. |
drashna
approved these changes
Oct 17, 2022
quinnyo
pushed a commit
to quinnyo/qmk_firmware
that referenced
this pull request
Oct 21, 2022
Fixes an issue in Ocean Dream that causes flashing after the oled screen times out and turns off. This occurs because writing to an OLED screen turns it on as well and we are both writing then immediately turning the screen off, but only if the timeout has occurred (no WPM, 30 seconds has passed).
aivalja
pushed a commit
to aivalja/qmk_firmware
that referenced
this pull request
Nov 7, 2022
Fixes an issue in Ocean Dream that causes flashing after the oled screen times out and turns off. This occurs because writing to an OLED screen turns it on as well and we are both writing then immediately turning the screen off, but only if the timeout has occurred (no WPM, 30 seconds has passed).
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Fixes an issue in Ocean Dream that causes flashing after the oled screen times out and turns off. This occurs because writing to an OLED screen turns it on as well and we are both writing then immediately turning the screen off, but only if the timeout has occurred (no WPM, 30 seconds has passed).
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Fixes an issue in Ocean Dream that causes flashing after the oled screen times out and turns off. This occurs because writing to an OLED screen turns it on as well and we are both writing then immediately turning the screen off, but only if the timeout has occurred (no WPM, 30 seconds has passed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in Ocean Dream that causes flashing after the oled screen
times out and turns off.
This occurs because writing to an OLED screen turns it on as well and we
are both writing then immediately turning the screen off, but only if
the timeout has occurred (no WPM, 30 seconds has passed).
Types of Changes
Issues Fixed or Closed by This PR
Checklist