Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup latinpadble #18736

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Fixup latinpadble #18736

merged 1 commit into from
Oct 15, 2022

Conversation

waffle87
Copy link
Member

Description

  • Remove unnecessary defines
  • Cleanup keymaps (via keymap lacking 4 layers, move encoder function to keyboard level)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

tz ci size check

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 15, 2022
@zvecr zvecr requested a review from a team October 15, 2022 19:41
@zvecr zvecr merged commit 4b5ebb7 into qmk:master Oct 15, 2022
@waffle87 waffle87 deleted the fix/latinpadble branch October 16, 2022 01:36
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@waffle87 @quinnyo
Fixup latinpadble (qmk#18736)
e669bb2
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@waffle87
Fixup latinpadble (qmk#18736)
319da1b
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Fixup latinpadble (qmk#18736)
3f1de12
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@waffle87 @nolanseaton
Fixup latinpadble (qmk#18736)
15d80c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @zvecr