-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snowe's KC_RESET to use QK_BOOT #18667
Conversation
I think this keymap needs overhauling in other areas (OLED code) for it to be contemporary? |
To be fair, I just wanted to fix only the compilation errors so that the CI run for #15741 doesn't fail due to snowe's keymap. So I didn't look further than the error log to check if other areas of the code could use an overhaul. |
@precondition thank you very much! I don't update my code very often so I very much do appreciate any help 😬. @keyboard-magpie what do I need to fix in the OLED code? A lot of it was very custom and qmk moves very fast and at the rate I update stuff (once a year lol) I get very out of date. |
I think it's as simple as adding |
haha is it really? man I thought it wasn't very popular judging by the limited number of responses on my reddit post 😅 . I would have kept expanding it if I knew it was popular! I haven't visited the discord in a long time lol. maybe I should go search my username on there 😫 I've wondered how to fix that flicker for a long time! I'm glad the fix is so simple! I'll do that right away. Thank you! |
Description
Update @snowe2010's crkbd keymap to use QK_BOOT instead of RESET.
PS: I'm not sure if editing user keymaps like that is really accepted but this PR is not too different from #18560 so I think it's ok
Types of Changes
Issues Fixed or Closed by This PR
Checklist