Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate various modifier defines #18638

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Relocate various modifier defines #18638

merged 2 commits into from
Mar 11, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 7, 2022 •
edited
Loading

Description

A new modifiers.h, containing mods_bit and MOD_MASK_*. Longer term, the plan is to convert this to data.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 7, 2022 22:44
@github-actions github-actions bot added the core label Oct 7, 2022
@zvecr zvecr marked this pull request as draft October 7, 2022 22:46
@drashna
Copy link
Member

drashna commented Oct 8, 2022

mods.h sounds like a good idea, to me.

Also, unit tests really don't like the location change.

@zvecr zvecr force-pushed the feature/relocate_mods branch from 9d43e3c to 0dc7d63 Compare February 6, 2023 01:41
@zvecr zvecr marked this pull request as ready for review February 6, 2023 02:31
@drashna drashna merged commit a974c51 into qmk:develop Mar 11, 2023
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@zvecr @coquizen
Relocate various modifier defines (qmk#18638)
05810de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc