ploopyco/trackball_mini: always update encoder #18561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The encoder derives scroll direction based on the last known wheel position, as such it needs up-to-date wheel state at all times to compute the right direction. When using opt_encoder_simple.c as the implementation, the default delay may cause the encoder to see "impossible" states (which requires recalibration) or states that imply an opposite direction to the actual scrolling direction. This is very evident when the wheel is free-spinning. This commit reorders the code to make sure the optical encoder state is always updated, but only apply scrolling when specified conditions are met (ie. after debounce period, middle mouse released, etc.). Tested with opt_encoder_simple.c, where a free-spinning wheel now generates very smooth scrolling with no apparent glitches. This has not been tested with the default encoder, but similar benefits should be found there.
|
Technically, should be applied to all of the ploopy devices. |
|
Thank you for your contribution! |
github-actions
bot
added
the
stale
drashna
approved these changes
Dec 27, 2022
github-actions
bot
removed
the
stale
tzarc
approved these changes
Dec 30, 2022
sbhal
pushed a commit
to sbhal/qmk_firmware
that referenced
this pull request
Dec 30, 2022
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jan 2, 2023
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The encoder derives scroll direction based on the last known wheel position, as such it needs up-to-date wheel state at all times to compute the right direction.
When using
opt_encoder_simple.cas the implementation, the default delay may cause the encoder to see "impossible" states (which requires recalibration) or states that imply an opposite direction to the actual scrolling direction. This is very evident when the wheel is free-spinning.This commit reorders the code to make sure the optical encoder state is always updated, but only apply scrolling when specified conditions are met (ie. after debounce period, middle mouse released, etc.).
Tested with
opt_encoder_simple.c, where a free-spinning wheel now generates very smooth scrolling with no apparent glitches. This has not been tested with the default encoder, but similar benefits should be found there.Since all Ploopy devices share the same encoder glue, this change can potentially be replicated to other devices for similar benefits.
Types of Changes
Checklist