Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotus58 Glow adding keyboard #18554

Closed
wants to merge 46 commits into from
Closed

Conversation

TweetyDaBird
Copy link
Contributor

Lotus 58 Glow

Adding Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/tweetydabird/lbs6/info.json Outdated Show resolved Hide resolved
data/schemas/keyboard.jsonschema Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/config.h Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/info.json Outdated Show resolved Hide resolved
keyboards/tweetydabird/lotus58/info.json Outdated Show resolved Hide resolved
@TweetyDaBird TweetyDaBird requested a review from zvecr September 30, 2022 22:42
@TweetyDaBird TweetyDaBird requested review from drashna and zvecr and removed request for zvecr and drashna October 7, 2022 14:23
@TweetyDaBird TweetyDaBird requested review from drashna and removed request for zvecr October 19, 2022 10:28
@TweetyDaBird
Copy link
Contributor Author

Tested this over a while now, and seems to work flawlessly.

Comment on lines +72 to +75
layer_state_t layer_state_set_kb(layer_state_t state) {
// Allow switching to the 'hidden' layer
return update_tri_layer_state(state, 1, 2, 3);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this being in the kb level code, since there isn't an easy way to override it.

Also:

Suggested change
layer_state_t layer_state_set_kb(layer_state_t state) {
// Allow switching to the 'hidden' layer
return update_tri_layer_state(state, 1, 2, 3);
}
layer_state_t layer_state_set_kb(layer_state_t state) {
// Allow switching to the 'hidden' layer
state = update_tri_layer_state(state, 1, 2, 3);
state = layer_state_set_user(state);
return state;
}

keyboards/tweetydabird/lotus58/lotus58.c Show resolved Hide resolved
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 15, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Feb 14, 2023
Copy link
Contributor Author

@TweetyDaBird TweetyDaBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented

@drashna drashna mentioned this pull request Apr 14, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants