-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lotus58 Glow adding keyboard #18554
Lotus58 Glow adding keyboard #18554
Conversation
Default and tester updated
typo
Layer toggle
typo
added thumb shift
Added CTRL arrow ModTap
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Tested this over a while now, and seems to work flawlessly. |
layer_state_t layer_state_set_kb(layer_state_t state) { | ||
// Allow switching to the 'hidden' layer | ||
return update_tri_layer_state(state, 1, 2, 3); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this being in the kb level code, since there isn't an easy way to override it.
Also:
layer_state_t layer_state_set_kb(layer_state_t state) { | |
// Allow switching to the 'hidden' layer | |
return update_tri_layer_state(state, 1, 2, 3); | |
} | |
layer_state_t layer_state_set_kb(layer_state_t state) { | |
// Allow switching to the 'hidden' layer | |
state = update_tri_layer_state(state, 1, 2, 3); | |
state = layer_state_set_user(state); | |
return state; | |
} |
Thank you for your contribution! |
Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented
Lotus 58 Glow
Adding Keyboard
Types of Changes
Checklist