Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add converter/xmk #18433

Merged
merged 6 commits into from
Dec 19, 2022
Merged

[Keyboard] Add converter/xmk #18433

merged 6 commits into from
Dec 19, 2022

Conversation

manna-harbour
Copy link
Contributor

@manna-harbour manna-harbour commented Sep 20, 2022 •
edited
Loading

Description

This PR adds new keyboard converter/xmk. This is the QMK keyboard definition for 𝑥MK.

Thanks!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@manna-harbour
Copy link
Contributor Author

manna-harbour commented Sep 25, 2022 •
edited
Loading

@drashna Thanks!

@manna-harbour
Copy link
Contributor Author

The requested changes have been made plus an extra small fix and additional feature, and this is again ready for review. Thanks!

@drashna drashna requested a review from a team October 21, 2022 05:18
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 17, 2022
@drashna drashna requested a review from a team December 17, 2022 19:30
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 18, 2022
@tzarc tzarc merged commit 5922751 into qmk:master Dec 19, 2022
@manna-harbour
Copy link
Contributor Author

Thanks everyone!

sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@manna-harbour
[Keyboard] Add converter/xmk (qmk#18433)
6bee688
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@manna-harbour @omikronik
[Keyboard] Add converter/xmk (qmk#18433)
b34a064
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@manna-harbour @ideas32
[Keyboard] Add converter/xmk (qmk#18433)
6b029e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manna-harbour @drashna @tzarc