Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elite-Pi converter #18236

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Add Elite-Pi converter #18236

merged 3 commits into from
Sep 8, 2022

Conversation

nooges
Copy link
Member

@nooges nooges commented Aug 31, 2022

Description

Add converter for Elite-Pi controller board

Pinout reference:

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the base branch from master to develop August 31, 2022 21:54
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also while i remember, does the Elite-Pi have vbus detection?

@drashna
Copy link
Member

drashna commented Sep 1, 2022

Should probably also add a "CONVERT_FROM=elite_c" option too.

@sadekbaroudi
Copy link
Contributor

Should probably also add a "CONVERT_FROM=elite_c" option too.

@drashna - why have a CONVERT_FROM parameter... there is only one option to convert from? This is fixed hardware with a fixed footprint and pinout. It's an unnecessary parameter. Just do right by the hardware. This is the same argument and issue I'm struggling with for #18239

@keyboard-magpie
Copy link
Contributor

What's wrong with considering these converters to be a general "convert from AVR" tool?

@zvecr
Copy link
Member

zvecr commented Sep 7, 2022

What's wrong with considering these converters to be a general "convert from AVR" tool?

Because pinout matters. trying to run this on something that uses an AVR teensy just wouldnt give the expected result.

Should probably also add a "CONVERT_FROM=elite_c" option too.

This is kind of what the PIN_COMPATIBLE option is intended for. Adding in a elite_c option is already possible. There could be an option for less duplication if there was a way to infer that a elite_c converter would also work for promicro but not the other way round.

@nooges nooges merged commit fb6e821 into qmk:develop Sep 8, 2022
@nooges nooges deleted the elite-pi branch September 8, 2022 18:59
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants