Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Ploopy Thumb Trackball #18214

Merged
merged 7 commits into from
Sep 26, 2022
Merged

[Keyboard] Ploopy Thumb Trackball #18214

merged 7 commits into from
Sep 26, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 30, 2022

Description

Taking over #14668.

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ploopyco and others added 2 commits August 29, 2022 20:30
@ploopyco @drashna
[Keyboard] Add Ploopy Thumb Trackball
e43be57 
thumb firmware, working

thumb button fixes

fixed doco

fixed layout for info.json

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Ryan <[email protected]>

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Ryan <[email protected]>

Update keyboards/ploopyco/trackball_thumb/readme.md

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.h

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/trackball_thumb.h

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Ryan <[email protected]>

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Ryan <[email protected]>

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Ryan <[email protected]>

Update keyboards/ploopyco/trackball_thumb/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

fixed the inverted pointer issue; everything is tested and looks okay

Update keyboards/ploopyco/trackball_thumb/rules.mk

Co-authored-by: Ryan <[email protected]>

Go all in on encoder hack

Apply suggestions from code review

Co-authored-by: Nick Brassel <[email protected]>

Apply suggestions from review
@drashna
Convert to data driven
18de2da
@drashna drashna requested a review from a team August 30, 2022 03:39
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 30, 2022
@drashna drashna mentioned this pull request Aug 30, 2022
Closed
14 tasks
keyboard-magpie
keyboard-magpie approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working nicely on my ploopy thumb trackball.

@blalor
Copy link

blalor commented Aug 30, 2022

On macOS my ploopy thumb is working fine with this change using the default keymap, but the drag_scroll one is not behaving properly. I'm using SteerMouse to map the buttons; it includes functionality to show which buttons are being pressed. It registers the stand-alone KC_BTN4 on the left-front button, as expected. Tapping the left-rear button does not register a click; tapping it again enables drag scroll; it takes two taps to leave drag scroll. I don't know if this is a drag scroll limitation, or an LT one, or maybe both?

@drashna
Copy link
Member Author

drashna commented Aug 30, 2022

for the drag scroll, I do need to investigate that, but since all of the ploopy boards share the code, it's something I'd prefer changing all at onec.

@drashna drashna requested a review from a team August 31, 2022 16:23
blalor added a commit to blalor/q3_qmk that referenced this pull request Sep 17, 2022
@blalor
Merge remote-tracking branch 'drashna/ploopyco/thumb' into blalor/plo…
94b8ecd 
…opyco/thumb

This brings in qmk#18214 qmk#18214
@drashna drashna merged commit b521641 into qmk:master Sep 26, 2022
@drashna drashna deleted the ploopyco/thumb branch September 26, 2022 06:15
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@drashna @fauxpark
@tzarc @ploopyco @tacahiroy
[Keyboard] Ploopy Thumb Trackball (qmk#18214)
2e6a06b 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
Co-authored-by: ploopyco <[email protected]>
@drashna drashna mentioned this pull request Nov 2, 2022
Merged
6 tasks
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@drashna @fauxpark
@tzarc @ploopyco
[Keyboard] Ploopy Thumb Trackball (qmk#18214)
c61f976 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
Co-authored-by: ploopyco <[email protected]>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@drashna @fauxpark
@tzarc @ploopyco @ramonimbao
[Keyboard] Ploopy Thumb Trackball (qmk#18214)
cbf38c1 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
Co-authored-by: ploopyco <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@drashna @fauxpark
@tzarc @ploopyco @nolanseaton
[Keyboard] Ploopy Thumb Trackball (qmk#18214)
87efcb9 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
Co-authored-by: ploopyco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@sigprof sigprof sigprof left review comments

@blalor blalor blalor requested changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drashna @blalor @sigprof @fauxpark @keyboard-magpie @ploopyco