Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move keyboard USB IDs and strings to data driven: develop #18152

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Move keyboard USB IDs and strings to data driven: develop #18152

merged 2 commits into from
Aug 24, 2022

Conversation

fauxpark
Copy link
Member

Description

I almost forgot about the boards that were merged directly to develop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 24, 2022 11:33
@zvecr zvecr merged commit cf41c24 into qmk:develop Aug 24, 2022
@fauxpark fauxpark deleted the keyboards-usb-data-driven-develop branch August 24, 2022 14:31
@BB-66 BB-66 mentioned this pull request Sep 11, 2022
Merged
6 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@fauxpark @nolanseaton
Move keyboard USB IDs and strings to data driven: develop (qmk#18152)
97763c5 
* Move keyboard USB IDs and strings to data driven: develop

* Also do new onekeys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @zvecr @daskygit