Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add om60 rev1 keyboard #18126

Merged
merged 19 commits into from
Sep 24, 2022
Merged

Add om60 rev1 keyboard #18126

merged 19 commits into from
Sep 24, 2022

Conversation

jun10000
Copy link
Contributor

@jun10000 jun10000 commented Aug 21, 2022 •
edited
Loading

Description

Initial PR for adding om60 rev1 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 21, 2022
drashna
drashna requested changes Aug 21, 2022
View reviewed changes
keyboards/om60/config.h Outdated Show resolved Hide resolved
keyboards/om60/config.h Outdated Show resolved Hide resolved
keyboards/om60/config.h Outdated Show resolved Hide resolved
keyboards/om60/config.h Outdated Show resolved Hide resolved
keyboards/om60/encoder.c Outdated Show resolved Hide resolved
keyboards/om60/readme.md Outdated Show resolved Hide resolved
keyboards/om60/rules.mk Outdated Show resolved Hide resolved
keyboards/om60/rules.mk Outdated Show resolved Hide resolved
keyboards/om60/om60.h Outdated Show resolved Hide resolved
keyboards/om60/om60.h Outdated Show resolved Hide resolved
jun10000 and others added 12 commits August 22, 2022 12:07
@jun10000 @drashna
Update keyboards/om60/config.h
e268bc0 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/config.h
ef97690 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/config.h
2ebf92c 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/info.json
ac06fbb 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/readme.md
24e665e 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/rules.mk
620470d 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/config.h
7991eab 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/rules.mk
9e97c7c 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/om60.h
11a4f5f 
Co-authored-by: Drashna Jaelre <[email protected]>
@jun10000 @drashna
Update keyboards/om60/om60.h
74da494 
Co-authored-by: Drashna Jaelre <[email protected]>
1. Removed encoder.c
feb273a 
2. Updated info.json
Updated many files
2a3228a 
1. Moved RGBLIGHT_SLEEP
2. Added Encoder Map feature
@drashna drashna requested a review from a team August 23, 2022 02:04
fauxpark
fauxpark requested changes Aug 25, 2022
View reviewed changes
keyboards/om60/info.json Show resolved Hide resolved
@jun10000 jun10000 requested a review from fauxpark August 30, 2022 05:12
@jun10000
Copy link
Contributor Author

jun10000 commented Sep 9, 2022

@fauxpark
Is there any problems?

fauxpark
fauxpark requested changes Sep 9, 2022
View reviewed changes
keyboards/om60/matrix.c Outdated Show resolved Hide resolved
@jun10000 jun10000 requested a review from fauxpark September 9, 2022 05:04
@jun10000
Copy link
Contributor Author

@fauxpark
Are there another problems?

@drashna drashna requested a review from a team September 14, 2022 04:21
drashna
drashna requested changes Sep 14, 2022
View reviewed changes
keyboards/om60/rules.mk Outdated Show resolved Hide resolved
@jun10000 jun10000 requested a review from drashna September 20, 2022 05:23
@drashna drashna merged commit 6cf4af9 into qmk:master Sep 24, 2022
@jun10000 jun10000 deleted the om60_new branch September 24, 2022 07:44
@jun10000 jun10000 mentioned this pull request Sep 24, 2022
Merged
6 tasks
mgor pushed a commit to mgor/qmk_firmware that referenced this pull request Sep 24, 2022
@jun10000 @drashna
@fauxpark @mgor
[Keyboard] Add om60 rev1 keyboard (qmk#18126)
e959b3c 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: jun10000 <[email protected]>
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@jun10000 @drashna
@fauxpark @tacahiroy
[Keyboard] Add om60 rev1 keyboard (qmk#18126)
cba12ab 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: jun10000 <[email protected]>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@jun10000 @drashna @fauxpark
[Keyboard] Add om60 rev1 keyboard (qmk#18126)
f5847ea 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: jun10000 <[email protected]>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@jun10000 @drashna
@fauxpark @ramonimbao
[Keyboard] Add om60 rev1 keyboard (qmk#18126)
2691a09 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: jun10000 <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@jun10000 @drashna
@fauxpark @nolanseaton
[Keyboard] Add om60 rev1 keyboard (qmk#18126)
7fca56e 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: jun10000 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jun10000 @drashna @fauxpark