Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DV_SCLN and DV_COLN in keymap_spanish_dvorak.h #18043

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

precondition
Copy link
Contributor

Description

Fix a small mix-up between KC_DOT and DV_DOT (idem for *_COMM)

commit 46e69851f8d699f95f13d9a9c32e234632527e7f (HEAD -> fix_dvorak_spanish_colon_keys, origin/fix_dvorak_spanish_colon_keys)
Author: precondition <[email protected]>
Date:   Sun Aug 14 21:02:41 2022 +0200

    Fix DV_SCLN and DV_COLN in keymap_spanish_dvorak.h

diff --git a/quantum/keymap_extras/keymap_spanish_dvorak.h b/quantum/keymap_extras/keymap_spanish_dvorak.h
index 29c4f1c44a..ea0c93f86a 100644
--- a/quantum/keymap_extras/keymap_spanish_dvorak.h
+++ b/quantum/keymap_extras/keymap_spanish_dvorak.h
@@ -114,8 +114,8 @@
 #define DV_QUES S(DV_QUOT) // ?
 #define DV_IQUE S(DV_IEXL) // ¿
 // Row 2
-#define DV_COLN S(KC_DOT)  // :
-#define DV_SCLN S(KC_COMM) // ;
+#define DV_COLN S(DV_DOT)  // :
+#define DV_SCLN S(DV_COMM) // ;
 #define DV_CIRC S(DV_GRV)  // ^ (dead)
 #define DV_ASTR S(DV_PLUS) // *
 // Row 3

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 14, 2022
@drashna drashna requested review from fauxpark and a team August 15, 2022 05:25
@zvecr zvecr added the bug label Aug 15, 2022
@zvecr zvecr merged commit 5021cf5 into qmk:develop Aug 15, 2022
@precondition precondition deleted the fix_dvorak_spanish_colon_keys branch August 15, 2022 20:32
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants