Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ; by : in the shifted symbols ASCII art of keymap_norman #18029

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Replace ; by : in the shifted symbols ASCII art of keymap_norman #18029

merged 1 commit into from
Aug 14, 2022

Conversation

precondition
Copy link
Contributor

Description

Fix the discrepancy between the ASCII art and NM_COLN.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization (as in better comments)
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 13, 2022
spidey3
spidey3 approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spidey3 spidey3 merged commit 0a6327d into qmk:develop Aug 14, 2022
@precondition precondition deleted the norman_colon_ascii_art branch August 14, 2022 17:36
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@precondition @nolanseaton
Replace ; by : in the shifted symbols ASCII art of keymap_norman (qmk…
85dee33 
…#18029)

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@precondition @drashna @spidey3