Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POINTING_DEVICE_GESTURES_SCROLL_ENABLE typo #17850

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fix POINTING_DEVICE_GESTURES_SCROLL_ENABLE typo #17850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df152c
Fix typo for POINTING_DEVICE_GESTURES_SCROLL_ENABLE
dkao Jul 30, 2022
401e8a9
Reword the blurb about POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE i…
dkao Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/feature_pointing_device.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ void pointing_device_driver_set_cpi(uint16_t cpi) {}
!> When using `SPLIT_POINTING_ENABLE` the `POINTING_DEVICE_MOTION_PIN` functionality is not supported and `POINTING_DEVICE_TASK_THROTTLE_MS` will default to `1`. Increasing this value will increase transport performance at the cost of possible mouse responsiveness.


!> **`POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE`** can be used with any pointing device with a lift/contact status can integrate this gesture into its driver. e.g. PMW3360 can use Lift_Stat from Motion register. Note that `POINTING_DEVICE_MOTION_PIN` cannot be used with this feature; continuous polling of `pointing_device_get_report()` is needed to generate glide reports.
!> Any pointing device with a lift/contact status can integrate inertial cursor feature into its driver, controlled by `POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE`. e.g. PMW3360 can use Lift_Stat from Motion register. Note that `POINTING_DEVICE_MOTION_PIN` cannot be used with this feature; continuous polling of `get_report()` is needed to generate glide reports.

## Split Keyboard Configuration

Expand Down
4 changes: 2 additions & 2 deletions drivers/sensors/cirque_pinnacle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@
# ifndef CIRQUE_PINNACLE_Y_RANGE
# define CIRQUE_PINNACLE_Y_RANGE (CIRQUE_PINNACLE_Y_UPPER - CIRQUE_PINNACLE_Y_LOWER)
# endif
# if defined(POINTING_DEVICE_GESTURE_SCROLL_ENABLE)
# if defined(POINTING_DEVICE_GESTURES_SCROLL_ENABLE)
# define CIRQUE_PINNACLE_CIRCULAR_SCROLL_ENABLE
# endif
#else
# define CIRQUE_PINNACLE_X_RANGE 256
# define CIRQUE_PINNACLE_Y_RANGE 256
# if defined(POINTING_DEVICE_GESTURE_SCROLL_ENABLE)
# if defined(POINTING_DEVICE_GESTURES_SCROLL_ENABLE)
# define CIRQUE_PINNACLE_SIDE_SCROLL_ENABLE
# endif
#endif
Expand Down