Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KBDfans Bounce75: correct keyboard name typos and Soldered version Refactor #17841

Merged
merged 8 commits into from
Jul 29, 2022
Merged

KBDfans Bounce75: correct keyboard name typos and Soldered version Refactor #17841

merged 8 commits into from
Jul 29, 2022

Conversation

noroadsleft
Copy link
Member

@noroadsleft noroadsleft commented Jul 29, 2022 •
edited
Loading

Description

  • corrects the typos that were meant to be corrected in KBDfans Bounce75 Touch-Up #17834. (I should make sure I've pushed the last commit when I open a PR 🤦‍♂️)
  • add four new layout macros to the Soldered version's support (combinations of ANSI/ISO and 2u/Split Backspace)

cc @moyi4681 (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
kbdfans/bounce/75: correct typos of keyboard name
d8dc882 
- `bonce` -> `bounce`
- `BONCE` -> `BOUNCE`
@noroadsleft noroadsleft requested a review from a team July 29, 2022 16:55
@noroadsleft
Copy link
Member Author

noroadsleft commented Jul 29, 2022 •
edited
Loading

Decided to extend the scope here and add some layouts.

@noroadsleft noroadsleft requested review from fauxpark and a team July 29, 2022 20:02
@zvecr zvecr merged commit 7f2ddf1 into qmk:master Jul 29, 2022
@noroadsleft noroadsleft changed the title kbdfans/bounce/75: correct typos of keyboard name KBDfans Bounce75: correct keyboard name typos and Soldered version Refactor Jul 29, 2022
@noroadsleft noroadsleft deleted the rf/kbdfans_bounce_75 branch July 29, 2022 23:58
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@noroadsleft @imhoffman
kbdfans/bounce/75: correct typos of keyboard name (qmk#17841)
427120b
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
kbdfans/bounce/75: correct typos of keyboard name (qmk#17841)
a9901ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr