Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate "Data Driven" migrations? #17820

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Automate "Data Driven" migrations? #17820

merged 1 commit into from
Nov 30, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 27, 2022 •
edited
Loading

Description

$ qmk migrate -kb zvecr/split_blackpill -f VENDOR_ID -f PRODUCT_ID
Ψ Migrating keyboard zvecr/split_blackpill.
Ψ   Migrating file keyboards/zvecr/split_blackpill/config.h
Ψ     Migrating PRODUCT_ID...
Ψ     Migrating VENDOR_ID...
Ψ   Migrating file keyboards/zvecr/split_blackpill/rules.mk
Ψ   Updating keyboards/zvecr/split_blackpill/info.json
Ψ Migration of keyboard zvecr/split_blackpill complete!
Ψ Verify build with qmk compile -kb zvecr/split_blackpill -km default

Might be of use for the current USB config -> DD efforts.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Jul 27, 2022
@zvecr zvecr marked this pull request as ready for review July 27, 2022 23:50
@zvecr zvecr requested review from fauxpark and a team July 27, 2022 23:51
@fauxpark
Copy link
Member

How disruptive is this to the rest of the info.json? They often have varying or mixed indentation, and may not follow the rules of InfoJSONEncoder. I'm aiming to minimise the diffs for ease of review, and the simplest (but obviously not the fastest) workflow I've come up with is to just make some snippets in Sublime and do it one board at a time.

@zvecr
Copy link
Member Author

zvecr commented Jul 28, 2022

It is more disruptive, mostly in the area of layout macros. Next iteration I plan to add will be for layout macros, so bulk changes in that area wont matter as much. Nothing will stop manual migrations, however an automated process potentially needs less review.

Longer term, info.json formatting is something that I want to add to PR validation.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 4, 2022
@tzarc tzarc removed the stale Issues or pull requests that have become inactive without resolution. label Oct 4, 2022
@tzarc
Copy link
Member

tzarc commented Oct 4, 2022

bad stalebot

tzarc
tzarc requested changes Oct 4, 2022
View reviewed changes
lib/python/qmk/cli/migrate.py Show resolved Hide resolved
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 19, 2022
@zvecr zvecr force-pushed the feature/cli_migrate branch 2 times, most recently from 737c866 to 8605f99 Compare November 20, 2022 22:22
@zvecr zvecr changed the base branch from master to develop November 20, 2022 22:23
@github-actions github-actions bot added core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support and removed cli qmk cli command python labels Nov 20, 2022
@zvecr zvecr force-pushed the feature/cli_migrate branch from 8605f99 to 5720683 Compare November 20, 2022 22:24
@github-actions github-actions bot added cli qmk cli command python labels Nov 20, 2022
@github-actions github-actions bot removed keymap core documentation keyboard via Adds via keymap and/or updates keyboard for via support translation labels Nov 20, 2022
@zvecr zvecr removed the stale Issues or pull requests that have become inactive without resolution. label Nov 20, 2022
@zvecr zvecr merged commit 3e59bbd into qmk:develop Nov 30, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Automate "Data Driven" migrations (qmk#17820)
f2af566
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Automate "Data Driven" migrations (qmk#17820)
56d8431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @fauxpark @tzarc