Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Caps Lock and Scroll Lock indicators to some Wilba Tech PCBs #17725

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add Caps Lock and Scroll Lock indicators to some Wilba Tech PCBs #17725

merged 1 commit into from
Sep 23, 2022

Conversation

wilba
Copy link
Contributor

@wilba wilba commented Jul 19, 2022

Some Wilba Tech PCBs which use a LED driver IC for mono through-hole LEDs only implemented a backlight function.
Some people really want just Caps Lock and Scroll Lock LEDs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@RagingPwner
Copy link

ne indicators avail

@srn2202
Copy link

srn2202 commented Sep 7, 2022

ne indicators avail

Sorry, none avail.

drashna
drashna approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this code should be migrated over to LED Matrix, ideally.

@drashna drashna requested a review from a team September 14, 2022 18:02
@nooges nooges merged commit 2791ceb into qmk:master Sep 23, 2022
mgor pushed a commit to mgor/qmk_firmware that referenced this pull request Sep 24, 2022
@wilba @mgor
Add caps lock and scroll lock indicators (qmk#17725)
de94774
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@wilba @tacahiroy
Add caps lock and scroll lock indicators (qmk#17725)
7b4922f
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@wilba
Add caps lock and scroll lock indicators (qmk#17725)
7d3fa94
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@wilba @ramonimbao
Add caps lock and scroll lock indicators (qmk#17725)
1dbb561
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@wilba @nolanseaton
Add caps lock and scroll lock indicators (qmk#17725)
1e60293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@nooges nooges nooges approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wilba @RagingPwner @srn2202 @nooges @drashna