-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Adjust PWM hardware audio driver for RP2040 #17723
Conversation
Sweet! Just tested this PR on my trusty Adafruit Macropad and can confirm that it is working amazingly -- albeit a little too loud for my taste but nonetheless amazing job as always! |
715fe4d
to
fc58954
Compare
fc58954
to
d4af24a
Compare
e1853e5
to
13583d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to break anything, at least.
@KarlK90 Thank you for writing this code set to support the audio feature on RP2040 chip! I can't wait merging this pull request because I would like to use the audio feature on the Lunakey Pico keyboard which was designed by me and is using Raspberry Pi Pico. Therefore, I tried testing this code by using my keyboard. The diff I created is the following: The circuit design of the Lunakey Pico is the following. The speaker is connected to the GP8 pin. When compiling the code set with the
I wrote the uf2 file and restarted my keyboard, unfortunately I was not able to hear any sounds. I have already confirmed that the speaker worked normally with KMK firmware. Did I forget to write something? Could you give me an advice to work the audio feature on my keyboard with your code? |
@Jpe230 Could you share me your code which you tried the audio feature using your keyboard? |
Sure, here it is |
Finally, I can hear the sound from my keyboard using the code: yoichiro@65a383e The cause is wrong combination of PWMn and Channel. It is necessary to use the PWM4 and the Channel A (= 1) for GP8. See: https://discordapp.com/channels/440868230475677696/1032861820228227132 I think that the diff of this pull request looks good to me and has comfirm that this code works normally. Thank you for the great contribution! |
13583d8
to
36685a8
Compare
...as we now use virtual timers for this task.
5178263
to
dfa3479
Compare
@KarlK90 Congrats! |
Description
Enables the usage of the PWM hardware audio driver to be used with the RP2040 MCU.
Types of Changes
Issues Fixed or Closed by This PR
Checklist