Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qmk doctor print out the last log entry for upstream/{master,develop}, including dates #17713

Merged
merged 6 commits into from
Jul 26, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 18, 2022

Description

Adds some extra qmk doctor logging output to show the latest commit for both upstream/master and upstream/develop.

Simplifies investigations on our side:

% qmk doctor
Ψ QMK Doctor is checking your environment.
Ψ CLI version: 1.1.0
Ψ QMK home: /home/nickb/qmk_build/qmk_firmware
Ψ Detected Linux.
Ψ Git branch: doctor-last-log-entries
Ψ Repo version: 0.17.5
Ψ - Latest doctor-last-log-entries: 2022-07-20 13:46:58 +1000 (f8d6d1571d) -- Add submodules, common ancestor.
Ψ - Latest upstream/master: 2022-07-20 01:55:48 +0100 (00c8e24c6a) -- [Keymap] Michal Keymap for Sofle rev1 (#17610)
Ψ - Latest upstream/develop: 2022-07-20 00:56:25 +0000 (fa44f2b21e) -- Merge remote-tracking branch 'origin/master' into develop
Ψ - Common ancestor with upstream/master: 2022-07-18 19:20:19 +0700 (c10d0fc785) -- Add Support for Massdrop's Stack Overflow The Key V2 (#17696)
Ψ - Common ancestor with upstream/develop: 2022-07-18 19:20:19 +0700 (c10d0fc785) -- Add Support for Massdrop's Stack Overflow The Key V2 (#17696)
Ψ CLI installed in virtualenv.
Ψ All dependencies are installed.
Ψ Found arm-none-eabi-gcc version 8.3.1
Ψ Found avr-gcc version 5.4.0
Ψ Found avrdude version 6.3-20171130
Ψ Found dfu-util version 0.9
Ψ Found dfu-programmer version 0.6.1
Ψ Submodules are up to date.
Ψ Submodule status:
Ψ - lib/chibios: 2021-12-08 11:37:03 +0000 -- svn-mirror/ver21.11.1 (257302333)
Ψ - lib/chibios-contrib: 2022-04-18 12:52:47 +0200 -- develop_2021_q3-198-g2a6b73ff (2a6b73ff)
Ψ - lib/googletest: 2021-06-11 06:37:43 -0700 -- release-1.10.0-681-ge2239ee6 (e2239ee6)
Ψ - lib/lufa: 2021-07-31 15:44:44 +1000 -- breakpoint_2021_08_28 (19a5d533f)
Ψ - lib/printf: 2020-01-01 18:16:48 +0100 -- v4.0.0-3-gd3b9846 (d3b9846)
Ψ - lib/vusb: 2020-08-16 01:07:21 +0100 -- releases/20121206-15-gbdb53e4 (bdb53e4)
Ψ QMK is ready to go

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from a team July 18, 2022 18:34
@github-actions github-actions bot added cli qmk cli command python labels Jul 18, 2022
@tzarc tzarc changed the base branch from develop to master July 18, 2022 18:35
@tzarc tzarc force-pushed the doctor-last-log-entries branch from d7ea611 to 66e7871 Compare July 18, 2022 18:35
@KarlK90
Copy link
Member

KarlK90 commented Jul 19, 2022

LGTM! While we are at it shall we add all the submodules as well?

@tzarc
Copy link
Member Author

tzarc commented Jul 20, 2022

Added submodules, as well as listing common ancestor with upstream/master and upstream/develop.

Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@zvecr zvecr merged commit d1434b6 into qmk:master Jul 26, 2022
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@tzarc tzarc deleted the doctor-last-log-entries branch August 3, 2022 01:38
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants