Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Use correct angle tune range of +/-30 on PMW33XX #17693

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 15, 2022

Description

...which is what the datasheet says.

image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90 KarlK90 requested a review from a team July 15, 2022 18:54
@KarlK90
Copy link
Member Author

KarlK90 commented Jul 15, 2022

CC: @dkao

@KarlK90 KarlK90 force-pushed the fix/pmw33xx-correct-angle-tune branch from a702b02 to 946c4e8 Compare July 15, 2022 18:55
@dkao
Copy link
Contributor

dkao commented Jul 16, 2022

@KarlK90 Thanks, looks good

@KarlK90 KarlK90 merged commit 580bcff into qmk:develop Jul 16, 2022
drashna added a commit that referenced this pull request Jul 17, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants