Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LED limits call #17679

Merged
merged 1 commit into from
Jul 14, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions quantum/rgb_matrix/animations/pixel_rain_anim.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,14 @@ RGB_MATRIX_EFFECT(PIXEL_RAIN)

static bool PIXEL_RAIN(effect_params_t* params) {
static uint32_t wait_timer = 0;
if (wait_timer > g_rgb_timer) {
return false;
}

inline uint32_t interval(void) {
return 500 / scale16by8(qadd8(rgb_matrix_config.speed, 16), 16);
}

bool rain_pixel(uint8_t i, effect_params_t * params, bool off) {
void rain_pixel(uint8_t i, effect_params_t * params, bool off) {
if (!HAS_ANY_FLAGS(g_led_config.flags[i], params->flags)) {
return true;
return;
}
if (off) {
rgb_matrix_set_color(i, 0, 0, 0);
Expand All @@ -40,10 +37,13 @@ static bool PIXEL_RAIN(effect_params_t* params) {
rgb_matrix_set_color(i, rgb.r, rgb.g, rgb.b);
}
wait_timer = g_rgb_timer + interval();
return false;
}

return rain_pixel(mod8(random8(), DRIVER_LED_TOTAL), params, random8() & 2);
RGB_MATRIX_USE_LIMITS(led_min, led_max);
if (g_rgb_timer > wait_timer) {
rain_pixel(mod8(random8(), DRIVER_LED_TOTAL), params, random8() & 2);
}
return rgb_matrix_check_finished_leds(led_max);
}

# endif // RGB_MATRIX_CUSTOM_EFFECT_IMPLS
Expand Down