Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix LED limit loop #17678

Merged
merged 1 commit into from
Jul 14, 2022
Merged

[Core] Fix LED limit loop #17678

merged 1 commit into from
Jul 14, 2022

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Jul 14, 2022 •
edited
Loading

Description

  • Ensure RGB_MATRIX_USE_LIMITS is called on every iteration
  • Use the smaller random8() function

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 14, 2022
@drashna drashna requested a review from a team July 14, 2022 06:49
@zvecr zvecr merged commit 1862ac5 into qmk:develop Jul 14, 2022
@filterpaper filterpaper deleted the raindrops-refactor branch July 14, 2022 11:38
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@filterpaper @nolanseaton
Fix the use of LED limits (qmk#17678)
1f3e46b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filterpaper @drashna @fauxpark @zvecr