Post-bootloader EFL/SPI fixes. #17661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Jul 13, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
* Fixup read address for EFL driver. * Fixup sequencing of SPI. * Lock during init of EFL backing store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EFL and SPI post-bootloader startup bugs, detected through assertions.
Under normal circumstances program code is mapped to
0x00000000as well as0x08000000.Post-bootloader, only the latter address is correct, so EFL is swapped to using the other location.
Also noted after bootloader is that the flash is already unlocked -- re-unlocking causes a fault and necessitates a restart.
Added explicit invocation of
backing_store_lock()duringbacking_store_init()to force it to be in the correct state.Invoking it even when locked is fine.
Also noted with debugging enabled that
spiUnselect()requires the peripheral to be in the stopped state - with assertions disabled this is ignored, but is obviously "wrong" as far as ChibiOS is concerned. Have removed the call.Types of Changes
Checklist