KBDfans KBD67 rev2 Layout Patch #17649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `LAYOUT_65_iso_split_bs` was actually previously implemented as split Spacebar with a 2u Backspace. Rename `LAYOUT_65_iso_split_bs` to `LAYOUT_65_iso_split_space`, and update layout data to match.
|
These changes required an edit to your keymap. Would appreciate a sign-off so we can get this in. |
zvecr
approved these changes
Jul 13, 2022
drashna
approved these changes
Jul 13, 2022
smocky
pushed a commit
to smocky/qmk_firmware
that referenced
this pull request
Jul 22, 2022
schattenbrot
pushed a commit
to schattenbrot/qmk_firmware
that referenced
this pull request
Aug 2, 2022
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
info.jsonLAYOUT_65_iso_split_bsto beLAYOUT_65_iso_split_spaceLAYOUT_65_iso_split_bswas actually previously implemented with a split Spacebar and a 2u (non-split) BackspaceLAYOUT_65_iso_split_bsThese changes necessitated an edit to the
naphtalinekeymap.Issues Fixed or Closed by This PR
LAYOUT_65_iso_split_bs(LAYOUT_65_iso_split_spacewith this PR applied):Types of Changes
Checklist