Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blok RP2040 converter #17603

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Add Blok RP2040 converter #17603

merged 1 commit into from
Jul 20, 2022

Conversation

filterpaper
Copy link
Contributor

Description

Add Promicro to Blok RP2040 converter that uses QMK_PM2040 board.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@keyboard-magpie
Copy link
Contributor

keyboard-magpie commented Jul 10, 2022 •
edited
Loading

Hey @filterpaper are you able to link to the blok pinout you have used to sanity check this?

edit: found. ignore. sanity checking commencing.

drashna
drashna reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__((weak)) ✅

@drashna drashna requested a review from a team July 11, 2022 11:29
@filterpaper
Copy link
Contributor Author

Depends on #17595

@zvecr zvecr requested a review from a team July 20, 2022 17:25
keyboard-magpie
keyboard-magpie approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I initially struggled to find the pinouts (boardsource need to publish those better) LGTM

@filterpaper
Copy link
Contributor Author

After I initially struggled to find the pinouts (boardsource need to publish those better) LGTM

Thank you. I agree than the pin out should be shared on the hardware product page, not deep inside the peg software website.

@zvecr zvecr merged commit d510e80 into qmk:develop Jul 20, 2022
@filterpaper filterpaper deleted the convert-to-blok branch July 21, 2022 00:45
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@filterpaper @nolanseaton
Add Blok 2040 conversion (qmk#17603)
83782f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filterpaper @keyboard-magpie @drashna @zvecr