Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Pixel Fractal effect #17602

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Refactor Pixel Fractal effect #17602

merged 3 commits into from
Aug 11, 2022

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Jul 9, 2022 •
edited by zvecr
Loading

Description

  • Halved array size to reduce memory footprint
  • Include RGB_MATRIX_USE_LIMITS()

Fixes #17589

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 9, 2022
@filterpaper filterpaper force-pushed the pixel-fractal-refactor branch from c7389c7 to 4fd13ee Compare July 9, 2022 03:04
@filterpaper filterpaper force-pushed the pixel-fractal-refactor branch from 4fd13ee to acb6b56 Compare July 9, 2022 03:06
@drashna drashna requested a review from a team July 10, 2022 23:23
@filterpaper filterpaper requested a review from drashna July 14, 2022 07:55
@filterpaper
Copy link
Contributor Author

Added fix for #17589

@filterpaper filterpaper changed the title Reduce Pixel Fractal effect array size Refactor Pixel Fractal effect Jul 14, 2022
drashna
drashna requested changes Jul 16, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint wants some formatting changes:

quantum/rgb_matrix/animations/pixel_fractal_anim.h Outdated Show resolved Hide resolved
quantum/rgb_matrix/animations/pixel_fractal_anim.h Outdated Show resolved Hide resolved
@filterpaper @drashna
Remove spaces
341961f 
Co-authored-by: Drashna Jaelre <[email protected]>
@filterpaper filterpaper requested a review from drashna July 17, 2022 01:24
@drashna drashna requested a review from a team July 21, 2022 17:20
@zvecr zvecr merged commit cde9dd8 into qmk:develop Aug 11, 2022
@filterpaper filterpaper deleted the pixel-fractal-refactor branch August 12, 2022 07:22
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@filterpaper @drashna @nolanseaton
Refactor Pixel Fractal effect (qmk#17602)
a546948 
* Refactor effect with smaller array

* Add RGB_MATRIX_USE_LIMITS call

* Remove spaces

Co-authored-by: Drashna Jaelre <[email protected]>

Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @zvecr