Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the ut472 keymap from gardego5 to the keyhive folder #17598

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

okin
Copy link

@okin okin commented Jul 8, 2022

Description

PR #16955 introduced a new keymap but did not honor the new structure introduced by #16084

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Right now the gardego5 keymap is unbuildable.
Moving it to the keyhive/ut472 keymap folder solves this.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

PR qmk#16955 introduced a new keymap but did not honor the new structure introduced by qmk#16084
@github-actions github-actions bot added the keymap label Jul 8, 2022
@zvecr
Copy link
Member

zvecr commented Jul 8, 2022

Pinging @Gardego5 as keymap maintainer.

@drashna drashna merged commit 068bfc4 into qmk:master Aug 2, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@okin okin deleted the move_gardego5_keymap_to_ut472_subfolder branch September 5, 2022 20:27
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants