Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add converter docs #17593

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Add converter docs #17593

merged 4 commits into from
Jul 8, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 7, 2022 •
edited
Loading

Description

Generalised https://docs.qmk.fm/#/proton_c_conversion where possible.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team July 7, 2022 22:54
@zvecr zvecr marked this pull request as ready for review July 7, 2022 22:54
KarlK90
KarlK90 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, reads very well and to the point. 👍

docs/feature_converters.md Outdated Show resolved Hide resolved
@zvecr @KarlK90
Update docs/feature_converters.md
bcc329a 
Co-authored-by: Stefan Kerkmann <[email protected]>
@zvecr zvecr merged commit 345e19f into qmk:develop Jul 8, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Add converter docs (qmk#17593)
2f3531e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @KarlK90