Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI Bugfix for ChibiOS 21.11.1 => 21.11.2 #17371

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jun 12, 2022

Description

Also rolls back the Mode0=>Mode3 "hack" for the AW20216 driver caused by the SPI bug.

Refer #17262, #17263, @trwnh it would be great if you could verify this fix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc marked this pull request as ready for review June 12, 2022 23:53
@tzarc tzarc added the bug label Jun 12, 2022
@tzarc tzarc changed the base branch from master to develop June 16, 2022 22:01
@tzarc tzarc force-pushed the chibios-21.11.2-bugfix branch from a7ad952 to daba64a Compare June 16, 2022 22:02
@tzarc tzarc merged commit 999b91f into qmk:develop Jun 16, 2022
@tzarc tzarc deleted the chibios-21.11.2-bugfix branch June 16, 2022 22:03
@trwnh
Copy link

trwnh commented Jun 19, 2022

Confirmed RGB LEDs still work after changing back to Mode 0 instead of Mode 3

@tzarc
Copy link
Member Author

tzarc commented Jun 19, 2022

Confirmed RGB LEDs still work after changing back to Mode 0 instead of Mode 3

Awesome, thanks for confirmation!

0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants