-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow encoder config from info.json #17295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much work would it be to support ENCODER_DIRECTION_FLIP
and ENCODER_DEFAULT_POS
in this PR? Because that would cover all the encoder features besides callbacks and encoder maps.
Once format has been decided, DD docs will be updated.
As the format seems pretty much nailed down this can be added now?
Otherwise LGTM!
|
|
Necro-ing here a tiny bit, I saw that the docs for encoders don't mention anything about info.json. Figured I'd draw attention to it. |
Description
Current plan is to munge https://docs.qmk.fm/#/feature_encoders into,
Once format has been decided, DD docs will be updated.
Types of Changes
Issues Fixed or Closed by This PR
Checklist