Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes terminal from QMK. #17258

Merged
merged 2 commits into from
May 31, 2022
Merged

Removes terminal from QMK. #17258

merged 2 commits into from
May 31, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented May 30, 2022

Description

This feature is all-but unused across QMK. We decided it was best to remove ancient code and simplify our maintenance.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team May 30, 2022 22:24
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label May 30, 2022
fauxpark
fauxpark approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SENDSTRING_BELL uses TERMINAL_SOUND, but it's defined in song_list.h. Maybe worth renaming.

@drashna drashna merged commit 8545473 into qmk:develop May 31, 2022
@KarlK90 KarlK90 mentioned this pull request Jun 5, 2022
Merged
14 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@tzarc @zykrah
Removes terminal from QMK. (qmk#17258)
1b86370
@tzarc tzarc deleted the rm-rf-terminal branch July 13, 2022 07:21
@kyrias kyrias mentioned this pull request Sep 18, 2022
Merged
14 tasks
kyrias added a commit to kyrias/qmk_firmware that referenced this pull request Sep 24, 2022
@kyrias
Remove remaining use of terminal keys and related comment labels
79edfea 
The terminal feature was removed in 8545473 (Removes terminal from
QMK. (qmk#17258), 2022-05-31).  This commit removes the remaining usages of
`TERM_{ON,OFF}` and removes the terminal key labels from the keymap
comments.
owodunni added a commit to owodunni/qmk_firmware that referenced this pull request Jul 23, 2023
@owodunni
Create owodunni's custom keymap that works well with programming
439be73 
The following has been my thoughts and inspiration when devloping my
planck layout:
* Took inspiration from BEAKL-27 for the symbol layers
https://ieants.cc/beakl/layouts.phpq
* Tried to make everything readable using ASCII art.
* Decided to keep colemak but modified it to colemak-dh mod
https://colemakmods.github.io/mod-dh/
*  Add some much needed comments and definitions regarding what
different QMK bools mean.
* Add instructions for where swedish keys are located
* Remove depricated QMK feature term_on qmk#17258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tzarc @drashna @fauxpark @zvecr @noroadsleft