[Keyboard] Move/Rename to Hillside48, simplify default keymap #17210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
python
via
|
An updated PR, now off develop to reflect recent develop changes of QK_BOOT and CAPS_WORD. Had been #16970 off master, which got hashed trying to move it to be off of develop. |
14 tasks
added 6 commits
May 26, 2022 14:30
- Three layers + adjust - Numbers in a row - Tab and ` on left of base
|
Resolved new merge conflict with develop. |
drashna
approved these changes
May 29, 2022
tzarc
approved these changes
Jul 2, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
) Co-authored-by: mmccoyd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename keyboard handwired/hillside/0_1 to handwired/hillside/48.
Simplify default keymap. Keymap changes:
Cleanup hillside keymap.json formating script.
Add SPLIT_USB_DETECT commented out option and note to keymap/default/config.h.
This rename deliberately does not touch hillside/readme.md. This way a separate PR adding hillside 52 can make the readme point to 48 and 52, without conflict between the two PRs.
Types of Changes
Issues Fixed or Closed by This PR
Checklist