Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AVR I2C master 1ms timeout #17174

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Fix AVR I2C master 1ms timeout #17174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23aadba
avr i2c_master: Fix 1ms timeout
dkao May 21, 2022
90fed55
avr/drivers/i2c_master: Use timer_elapsed()
dkao Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions platforms/avr/drivers/i2c_master.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ static i2c_status_t i2c_start_impl(uint8_t address, uint16_t timeout) {

uint16_t timeout_timer = timer_read();
while (!(TWCR & (1 << TWINT))) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) >= timeout)) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) > timeout)) {
dkao marked this conversation as resolved.
Show resolved Hide resolved
return I2C_STATUS_TIMEOUT;
}
}
Expand All @@ -81,7 +81,7 @@ static i2c_status_t i2c_start_impl(uint8_t address, uint16_t timeout) {

timeout_timer = timer_read();
while (!(TWCR & (1 << TWINT))) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) >= timeout)) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) > timeout)) {
dkao marked this conversation as resolved.
Show resolved Hide resolved
return I2C_STATUS_TIMEOUT;
}
}
Expand All @@ -102,7 +102,7 @@ i2c_status_t i2c_start(uint8_t address, uint16_t timeout) {
i2c_status_t status;
do {
status = i2c_start_impl(address, time_slice);
} while ((status < 0) && ((timeout == I2C_TIMEOUT_INFINITE) || (timer_elapsed(timeout_timer) < timeout)));
} while ((status < 0) && ((timeout == I2C_TIMEOUT_INFINITE) || (timer_elapsed(timeout_timer) <= timeout)));
return status;
}

Expand All @@ -114,7 +114,7 @@ i2c_status_t i2c_write(uint8_t data, uint16_t timeout) {

uint16_t timeout_timer = timer_read();
while (!(TWCR & (1 << TWINT))) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) >= timeout)) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) > timeout)) {
dkao marked this conversation as resolved.
Show resolved Hide resolved
return I2C_STATUS_TIMEOUT;
}
}
Expand All @@ -132,7 +132,7 @@ int16_t i2c_read_ack(uint16_t timeout) {

uint16_t timeout_timer = timer_read();
while (!(TWCR & (1 << TWINT))) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) >= timeout)) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) > timeout)) {
dkao marked this conversation as resolved.
Show resolved Hide resolved
return I2C_STATUS_TIMEOUT;
}
}
Expand All @@ -147,7 +147,7 @@ int16_t i2c_read_nack(uint16_t timeout) {

uint16_t timeout_timer = timer_read();
while (!(TWCR & (1 << TWINT))) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) >= timeout)) {
if ((timeout != I2C_TIMEOUT_INFINITE) && ((timer_read() - timeout_timer) > timeout)) {
dkao marked this conversation as resolved.
Show resolved Hide resolved
return I2C_STATUS_TIMEOUT;
}
}
Expand Down