Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Dumbpad v1x_oled #17058

Merged
merged 12 commits into from
Aug 7, 2022
Merged

[Keyboard] Dumbpad v1x_oled #17058

merged 12 commits into from
Aug 7, 2022

Conversation

medoix
Copy link

@medoix medoix commented May 11, 2022

Description

This PR adds the QMK config files for the Dumbpad v1x_oled variant

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 11, 2022
@medoix medoix mentioned this pull request May 11, 2022
Open
zvecr
zvecr requested changes May 11, 2022
View reviewed changes
keyboards/dumbpad/v1x_oled/config.h Outdated Show resolved Hide resolved
keyboards/dumbpad/v1x_oled/keymaps/via/rules.mk Outdated Show resolved Hide resolved
medoix and others added 2 commits May 12, 2022 07:51
@medoix @zvecr
Update keyboards/dumbpad/v1x_oled/config.h
6c1fb51 
Swap encoder pin mapping instead of using direction flip

Co-authored-by: Joel Challis <[email protected]>
@medoix @zvecr
Update keyboards/dumbpad/v1x_oled/keymaps/via/rules.mk
ed0ec70 
enable LTO instead of setting the flags

Co-authored-by: Joel Challis <[email protected]>
@medoix medoix requested a review from zvecr May 11, 2022 21:53
drashna
drashna requested changes May 12, 2022
View reviewed changes
keyboards/dumbpad/v1x_oled/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dumbpad/v1x_oled/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dumbpad/v1x_oled/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dumbpad/v1x_oled/v1x_oled.c Show resolved Hide resolved
keyboards/dumbpad/v1x_oled/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@imchipwood imchipwood mentioned this pull request Jul 6, 2022
Closed
@medoix medoix requested a review from drashna July 25, 2022 08:33
drashna
drashna reviewed Jul 26, 2022
View reviewed changes
keyboards/dumbpad/v1x_oled/rules.mk Outdated Show resolved Hide resolved
keyboards/dumbpad/v1x_oled/v1x_oled.c Outdated Show resolved Hide resolved
@medoix medoix requested a review from drashna July 26, 2022 08:34
@drashna drashna requested a review from a team July 26, 2022 21:25
@medoix
Copy link
Author

medoix commented Jul 28, 2022

@zvecr any additional feedback or can we please merge this in?

@medoix
Copy link
Author

medoix commented Aug 3, 2022 •
edited
Loading

bump, can someone please review/approve/merge 🙏

fauxpark
fauxpark requested changes Aug 3, 2022
View reviewed changes
keyboards/dumbpad/v1x_oled/rules.mk Show resolved Hide resolved
keyboards/dumbpad/v1x_oled/rules.mk Outdated Show resolved Hide resolved
@medoix medoix requested a review from fauxpark August 3, 2022 05:06
@drashna drashna merged commit b9269bf into qmk:master Aug 7, 2022
@medoix medoix mentioned this pull request Aug 7, 2022
Merged
6 tasks
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@medoix @zvecr
@drashna @fauxpark @imhoffman
[Keyboard] Dumbpad v1x_oled (qmk#17058)
7e46181 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@medoix @zvecr
@drashna @fauxpark @nolanseaton
[Keyboard] Dumbpad v1x_oled (qmk#17058)
0505a11 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@medoix @drashna @fauxpark @zvecr @keyboard-magpie