Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add banime40 keyboard to keyboards #16694
add banime40 keyboard to keyboards #16694
Changes from 2 commits
5d99d2f
9d6551c
922985b
137bb6a
5ac5de2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is set to 10, then you need to have 10 layers defined for the VIA keymap. This way that all of the layers are populated proper on initialization, rather than filled with random junk.
That or, this needs to be set to 4 (or removed, as 4 is the default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I've added the 6 missing layers (I might need more than 4 layers for a keyboard of this size 😳)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This board appears to be using an atmega32u4, which, at best is pushing the 1kb of eeprom space that the controller has.
Does the VIA keymap even compile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the VIA keymap compiles and is fully usable in VIAL. I'm guessing one of the reasons why I can get away with it, despite using an ATmega32U4, is just due to the key count of the board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. ~800 bytes for, plus ~35 for QMK stuff, leaving ~150 for macros. A close fit, but ...