Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinesis80 #16678

Closed
wants to merge 35 commits into from
Closed

Kinesis80 #16678

wants to merge 35 commits into from

Conversation

DmNosachev
Copy link
Contributor

Kinesis80 — controller for modded Kinesis Contoured keyboards (PCB)

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@masters3d
Copy link

masters3d commented Mar 17, 2022 •
edited
Loading

I would recommend a name that does not include the company name unless this is sponsored by them. For discoverability you can add this info to the readme.

drashna
drashna requested changes Mar 18, 2022
View reviewed changes
keyboards/kinesis80/blackpill103/blackpill103.h Outdated Show resolved Hide resolved
keyboards/kinesis80/blackpill401/blackpill401.h Outdated Show resolved Hide resolved
keyboards/kinesis80/blackpill411/blackpill411.h Outdated Show resolved Hide resolved
keyboards/kinesis80/blackpill411/chconf.h Outdated Show resolved Hide resolved
keyboards/kinesis80/config.h Outdated Show resolved Hide resolved
keyboards/kinesis80/keymaps/andrew/keymap.c Outdated Show resolved Hide resolved
keyboards/kinesis80/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/kinesis80/keymaps/default/keymap.c Outdated Show resolved Hide resolved
DmNosachev and others added 8 commits March 18, 2022 13:43
@DmNosachev DmNosachev requested a review from drashna March 21, 2022 07:27
drashna
drashna requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have changes to your submodules that need to be reverted.

keyboards/kin80/blackpill103/config.h Outdated Show resolved Hide resolved
keyboards/kin80/blackpill103/blackpill103.c Outdated Show resolved Hide resolved
keyboards/kin80/blackpill103/rules.mk Outdated Show resolved Hide resolved
keyboards/kin80/blackpill411/rules.mk Outdated Show resolved Hide resolved
keyboards/kin80/keymaps/andrew/keymap.c Outdated Show resolved Hide resolved
keyboards/kin80/keymaps/quartz64/keymap.c Outdated Show resolved Hide resolved
keyboards/kin80/keymaps/quartz64/keymap.c Outdated Show resolved Hide resolved
keyboards/kin80/keymaps/roman/keymap.c Outdated Show resolved Hide resolved
keyboards/kin80/readme.md Show resolved Hide resolved
keyboards/kin80/rules.mk Outdated Show resolved Hide resolved
DmNosachev and others added 11 commits March 24, 2022 15:11
@DmNosachev @drashna
Update keyboards/kin80/blackpill103/config.h
05d35d3 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/blackpill103/blackpill103.c
c43a533 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/keymaps/quartz64/keymap.c
fb274e3 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/keymaps/default/keymap.c
06e04f3 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/keymaps/quartz64/keymap.c
28994d8 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/rules.mk
158dead 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/blackpill103/rules.mk
ddcc2b7 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/blackpill411/rules.mk
3de0b70 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/keymaps/andrew/keymap.c
1de4b2b 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/keymaps/roman/keymap.c
94638e0 
Co-authored-by: Drashna Jaelre <[email protected]>
@DmNosachev @drashna
Update keyboards/kin80/keymaps/maxim/keymap.c
e63f6b4 
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna requested a review from a team March 26, 2022 00:49
fauxpark
fauxpark requested changes Mar 26, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submodule changes need to be reverted.

keyboards/kin80/blackpill401/rules.mk Outdated Show resolved Hide resolved
keyboards/kin80/blackpill103/blackpill103.c Outdated Show resolved Hide resolved
keyboards/kin80/keymaps/debug/rules.mk Outdated Show resolved Hide resolved
keyboards/kin80/keymaps/maxim/keymap.c Outdated Show resolved Hide resolved
keyboards/kin80/keymaps/quartz64/keymap.c Outdated Show resolved Hide resolved
keyboards/kin80/micro/rules.mk Outdated Show resolved Hide resolved
keyboards/kin80/readme.md Outdated Show resolved Hide resolved
@DmNosachev
Copy link
Contributor Author

It looks like I did something weird with the submodules here and don't know how to fix it.
Perhaps I will close this pull request, delete the branch and create it again.

@DmNosachev DmNosachev closed this Mar 30, 2022
@DmNosachev DmNosachev deleted the kinesis80 branch March 30, 2022 11:06
@DmNosachev DmNosachev mentioned this pull request Mar 30, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna requested changes

Assignees
No one assigned
Labels
dependencies keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DmNosachev @masters3d @drashna @fauxpark