Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force platform pin defs to be included #16611

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Force platform pin defs to be included #16611

merged 2 commits into from
Mar 10, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 10, 2022 •
edited
Loading

Description

Cherry picked from #16598.

Sometimes NO_PIN is not defined, and instead the platform header is picked up off the include path first.

Similar changes have previously been made for wait.h/_wait.h.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review March 10, 2022 21:28
@github-actions github-actions bot added the core label Mar 10, 2022
@zvecr zvecr requested a review from a team March 10, 2022 21:30
@zvecr zvecr merged commit 7e6f1c9 into qmk:develop Mar 10, 2022
@zvecr zvecr deleted the feature/converters2 branch March 11, 2022 00:03
@zvecr zvecr mentioned this pull request Mar 11, 2022
Merged
14 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @zykrah
Force platform pin defs to be included (qmk#16611)
581e42a 
* Force platform pin defs to be included

* Always grab first header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark