Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonix sn32f2xx platform support #16510

Closed
wants to merge 6 commits into from
Closed

sonix sn32f2xx platform support #16510

wants to merge 6 commits into from

Conversation

dexter93
Copy link
Contributor

@dexter93 dexter93 commented Mar 3, 2022

Includes #16339

Requires ChibiOS/ChibiOS-Contrib#317

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels Mar 3, 2022
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪

Nits so far: Documentation changes for supported MCUs are missing and AFAIK every new supported platform on QMK requires a corresponding onekey keyboard in the handwired folder.

platforms/chibios/bootloaders/sn32_dfu.c Outdated Show resolved Hide resolved
@dexter93
Copy link
Contributor Author

dexter93 commented Mar 3, 2022

Thanks! Docs will be added. Downside on that is that most of the keyboards on the platform require non-standard matrix setup, will follow that with a new commit soon.

Great work! muscle

Nits so far: Documentation changes for supported MCUs are missing and AFAIK every new supported platform on QMK requires a corresponding onekey keyboard in the handwired folder.

@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Mar 3, 2022
@drashna drashna requested review from fauxpark, sigprof, zvecr and a team March 3, 2022 22:03
@StartForKiller
Copy link

StartForKiller commented Mar 31, 2022

If this works then some keyboard like last version of gmmk 1(rev3 VS11K13A) would be viable

@tzarc
Copy link
Member

tzarc commented Jul 7, 2022

Have created a PR -- dexter93#10 -- which does some cleanup and removes the unused emulated EEPROM stuff.

Still needs some handwired/onekey variants created.

@tzarc
Copy link
Member

tzarc commented Aug 13, 2022

Original author has gone on sabbatical or equivalent. Suggest someone else raises a PR once it's ready.

@tzarc tzarc closed this Aug 13, 2022
@dexter93 dexter93 mentioned this pull request Oct 12, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting_pr Relies on another PR to be merged first cli qmk cli command core documentation python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants