Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jels88 #16486

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Update Jels88 #16486

merged 1 commit into from
Mar 7, 2022

Conversation

Jels02
Copy link
Contributor

@Jels02 Jels02 commented Mar 1, 2022 •
edited
Loading

I noticed there were some issues with my files, figured I should update them.

Description

  • Fixed a broken link in readme
  • Fixed iso layout in [keyboard].h to have pipe key next to left shift
  • Added ansi and iso to info.json

Types of Changes

  • Bugfix
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Issues Fixed or Closed by This PR

  • Broken link in readme
  • Incorrect iso layout
  • Missing ansi and iso in info.json

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Jels02
Update Jels88
f2fd2d6 
-Fix link in readme
-Fix iso layout
-add ansi and iso to info.json
@drashna drashna requested a review from a team March 7, 2022 04:18
@drashna
Copy link
Member

drashna commented Mar 7, 2022

Thanks!

@drashna drashna merged commit 9dea8a7 into qmk:master Mar 7, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Jels02 @zykrah
[Keyboard] Update Jels88 (qmk#16486)
f1d6b1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jels02 @drashna @fauxpark