Revert "handwired/3dortho14u: refactor layout data" #16485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ac769b.
github-actions
bot
added
keyboard
keymap
via
|
I was actually just about to open a PR that adds the full ortho back in, along with two other layouts (combinations of 2u or Split Enter, and full ortho or 6u spacebar bottom row).
But if you'd prefer to just revert, let me know. |
|
There's also a layout with a vertical 2u enter and kp plus as well as a 2u kp insert. Existing boards e.g. clueboard have a matrix that supports split shifts, split backspace etc in the default keymap. It seems easier to revert than to make a keymap for every possible permutation imo. |
|
heres the kle of the intended layouts |
|
Good reference on the intended layouts. Merging... |
|
thank you |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16475
This keyboard supports all 1u layout if wired so. The 3d models provision these layouts.
Please see conversation with PR author @noroadsleft acknowledging this capability. #16475