Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move projectcain encoder logic to keyboard level #16479

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 1, 2022

Description

From https://yanfali.github.io/qmk_error_page/

Ψ Compiling keymap with make -s --jobs=1 -r -R -f builddefs/build_keyboard.mk KEYBOARD=projectcain/vault35 KEYMAP=default_configurator KEYBOARD_FILESAFE=projectcain_vault35 TARGET=projectcain_vault35_default_configurator KEYBOARD_OUTPUT=.build/obj_projectcain_vault35 KEYMAP_OUTPUT=.build/obj_projectcain_vault35_default_configurator MAIN_KEYMAP_PATH_1=.build/obj_projectcain_vault35_default_configurator MAIN_KEYMAP_PATH_2=.build/obj_projectcain_vault35_default_configurator MAIN_KEYMAP_PATH_3=.build/obj_projectcain_vault35_default_configurator MAIN_KEYMAP_PATH_4=.build/obj_projectcain_vault35_default_configurator MAIN_KEYMAP_PATH_5=.build/obj_projectcain_vault35_default_configurator KEYMAP_C=.build/obj_projectcain_vault35_default_configurator/src/keymap.c KEYMAP_PATH=.build/obj_projectcain_vault35_default_configurator/src VERBOSE=false COLOR=true SILENT=false QMK_BIN="qmk"


avr-gcc (GCC) 5.4.0
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiling: keyboards/projectcain/vault35/vault35.c                                                 �[01m�[Kkeyboards/projectcain/vault35/vault35.c:�[m�[K In function ‘�[01m�[Kencoder_update_kb�[m�[K’:
�[01m�[Kkeyboards/projectcain/vault35/vault35.c:20:10:�[m�[K �[01;31m�[Kerror: �[m�[Kimplicit declaration of function ‘�[01m�[Kencoder_update_user�[m�[K’ [-Werror=implicit-function-declaration]
     if (!encoder_update_user(index, clockwise)) { return false; }
�[01;32m�[K          ^�[m�[K
cc1: all warnings being treated as errors
 �[31;01m[ERRORS]�[0m
 | 
 | 
 | 
make: *** [builddefs/common_rules.mk:456: .build/obj_projectcain_vault35_default_configurator/keyboards/projectcain/vault35/vault35.o] Error 1

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 1, 2022
@zvecr zvecr requested a review from a team March 1, 2022 01:17
@zvecr zvecr merged commit c9d9e70 into qmk:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants