Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analog.[ch]: remove unnecessary includes #16471

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

fauxpark
Copy link
Member

Description

Most things do not need to include the entirety of quantum.h and everything it pulls in.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Feb 28, 2022

This breaks the analog_joystick driver. Not sure if that should be addressed here, or in a separate PR. But either way, it now needs:

#include "timer.h"
#include <stdlib.h>

@fauxpark fauxpark merged commit d412854 into qmk:master Mar 4, 2022
@fauxpark fauxpark deleted the analog-includes branch March 4, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Compilation error when enabling both Bluetooth and pointer device
3 participants