Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omega4 firmware #16464

Merged
merged 6 commits into from
Mar 10, 2022
Merged

omega4 firmware #16464

merged 6 commits into from
Mar 10, 2022

Conversation

makenova
Copy link
Contributor

@makenova makenova commented Feb 27, 2022 •
edited
Loading

Description

Adding the Omega4 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Feb 27, 2022
View reviewed changes
keyboards/makenova/omega/omega4/omega4.h Outdated Show resolved Hide resolved
@makenova makenova requested a review from zvecr February 28, 2022 02:38
@makenova makenova marked this pull request as ready for review February 28, 2022 02:38
drashna
drashna reviewed Mar 7, 2022
View reviewed changes
keyboards/makenova/omega/omega4/info.json Outdated Show resolved Hide resolved
keyboards/makenova/omega/omega4/config.h Outdated Show resolved Hide resolved
keyboards/makenova/omega/omega4/rules.mk Outdated Show resolved Hide resolved
keyboards/makenova/omega/omega4/rules.mk Outdated Show resolved Hide resolved
@makenova makenova requested a review from drashna March 7, 2022 08:21
drashna
drashna reviewed Mar 8, 2022
View reviewed changes
docs/pr_checklist.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 8, 2022 16:33
fauxpark
fauxpark requested changes Mar 8, 2022
View reviewed changes
keyboards/makenova/omega/omega4/config.h Outdated Show resolved Hide resolved
keyboards/makenova/omega/omega4/rules.mk Outdated Show resolved Hide resolved
keyboards/makenova/omega/omega4/info.json Outdated Show resolved Hide resolved
@makenova makenova requested a review from fauxpark March 9, 2022 18:57
@drashna
Copy link
Member

drashna commented Mar 10, 2022

Thanks!

@drashna drashna merged commit 265b96a into qmk:master Mar 10, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@makenova @zykrah
[Keyboard] Add omega4 (qmk#16464)
22a8325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makenova @drashna @fauxpark @zvecr